Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build out CI workflow with linting, testing, and checking for stale translation files #23

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jessepinho
Copy link
Collaborator

@jessepinho jessepinho commented Jan 6, 2025

In this PR

  • Run linting and testing in CI
  • Run yarn extract && yarn compile, then check if the Git tree is dirty, and fail the job if it is. This ensures that devs don't forget to extract/compile their translatable strings.
  • Cache node_modules between builds so that they don't have to be reinstalled every time.
  • Fix existing linting issues.
  • Update translation files (which CI now catches, per above!).

@jessepinho jessepinho force-pushed the jessepinho/testing-ci-2 branch from e4acfe5 to 03847f8 Compare January 6, 2025 21:56
@jessepinho jessepinho force-pushed the jessepinho/testing-ci-2 branch from 23e1b72 to d37c808 Compare January 6, 2025 23:02
@jessepinho jessepinho force-pushed the jessepinho/testing-ci-2 branch from 5040e4c to 92077ce Compare January 6, 2025 23:11
@jessepinho jessepinho marked this pull request as ready for review January 6, 2025 23:35
@jessepinho jessepinho changed the title Fix workflow Build out CI workflow with linting, testing, and checking for stale translation files Jan 6, 2025
@jessepinho jessepinho requested a review from TalDerei January 6, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant